]> dgit.raspbian.org Git - gnome-shell.git/commit
runDialog: Require matching key-press for ESC shortcut
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 3 Jan 2025 23:17:53 +0000 (00:17 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Fri, 10 Jan 2025 11:46:14 +0000 (12:46 +0100)
commit2580bfe2d59d53ebf24f611ac33382f3397dcdb3
treee57f1a43441cdbdab2dd25a7bca30b5d653681f5
parent4aa0bd9e0f035f24b07adb0197c3af4c6ce5a662
runDialog: Require matching key-press for ESC shortcut

Both popover menus and dialogs can be dismissed with the Escape key,
however the former triggers on key press, while the latter triggers
on key release. As a result, the same key press+release can dismiss
both the command entry's context menu and the run dialog itself.

Fix this by only triggering a key shortcut when a matching key press
was recorded before, which matches how Dialog handles button shortcuts.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8132
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3585>
(cherry picked from commit 9b9191e8585025eb038d08fa63227f46a4b22cb8)
js/ui/runDialog.js